lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/3] exfat: remove useless check in exfat_move_file()
Date
> In exfat_move_file(), the identity of source and target directory has been
> checked by the caller.
> Also, it gets stream.start_clu from file dir-entry, which is an invalid
> determination.
>
> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com>
> ---
> fs/exfat/namei.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index
> 803748946ddb..1c433491f771 100644
> --- a/fs/exfat/namei.c
> +++ b/fs/exfat/namei.c
> @@ -1095,11 +1095,6 @@ static int exfat_move_file(struct inode *inode,
> struct exfat_chain *p_olddir,
> if (!epmov)
> return -EIO;
>
> - /* check if the source and target directory is the same */
> - if (exfat_get_entry_type(epmov) == TYPE_DIR &&
> - le32_to_cpu(epmov->dentry.stream.start_clu) == p_newdir->dir)
> - return -EINVAL;
> -

It might check if the cluster numbers are same between source entry and
target directory.
Could you let me know what code you mentioned?
Or do you mean the codes on vfs?

> num_old_entries = exfat_count_ext_entries(sb, p_olddir, oldentry,
> epmov);
> if (num_old_entries < 0)
> --
> 2.25.1


\
 
 \ /
  Last update: 2020-09-16 04:32    [W:0.050 / U:4.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site