lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] soc: renesas: r8a779a0-sysc: Make r8a779a0_sysc_info static
From
Date
On 2020/9/15 23:22, Geert Uytterhoeven wrote:
> Hi Yue,
>
> On Tue, Sep 15, 2020 at 4:58 PM YueHaibing <yuehaibing@huawei.com> wrote:
>> Fix sparse warning:
>>
>> drivers/soc/renesas/r8a779a0-sysc.c:99:33: warning: symbol 'r8a779a0_sysc_info' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> As commit 7f29315cf4211316 ("soc: renesas: r8a779a0-sysc: Add r8a779a0
> support") hasn't been merged into arm-soc yet, is it OK for you if I
> just fold your fix into the original commit?

Sure, it's ok for me.
>
> Thanks again!
>
>> --- a/drivers/soc/renesas/r8a779a0-sysc.c
>> +++ b/drivers/soc/renesas/r8a779a0-sysc.c
>> @@ -96,7 +96,7 @@ static struct r8a779a0_sysc_area r8a779a0_areas[] __initdata = {
>> { "a1dsp1", R8A779A0_PD_A1DSP1, R8A779A0_PD_A2CN1 },
>> };
>>
>> -const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = {
>> +static const struct r8a779a0_sysc_info r8a779a0_sysc_info __initconst = {
>> .areas = r8a779a0_areas,
>> .num_areas = ARRAY_SIZE(r8a779a0_areas),
>> };
>
> Gr{oetje,eeting}s,
>
> Geert
>

\
 
 \ /
  Last update: 2020-09-16 03:27    [W:0.056 / U:9.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site