lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] spi: xilinx: Fix info message during probe
From
Date


On 15. 09. 20 13:29, Ricardo Ribalda wrote:
> The info message was showing the mapped address of the device. To avoid
> security problems, all virtual addresses are converted to __ptrval__, so
> the message was useless/ugly:
>
> [ 2.304949] xilinx_spi b0010000.spi-flash: at 0xB0010000 mapped to 0x(____ptrval____), irq=37
>
> Use %pR instead:
>
> [ 15.021354] xilinx_spi b0010000.spi-flash: at [mem 0xb0010000-0xb001ffff], irq=37
>
> Signed-off-by: Ricardo Ribalda <ribalda@kernel.org>
> ---
> drivers/spi/spi-xilinx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 8dd2bb99cb4d..523edfdf5dcd 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -491,8 +491,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> goto put_master;
> }
>
> - dev_info(&pdev->dev, "at 0x%08llX mapped to 0x%p, irq=%d\n",
> - (unsigned long long)res->start, xspi->regs, xspi->irq);
> + dev_info(&pdev->dev, "at %pR, irq=%d\n", res, xspi->irq);
>
> if (pdata) {
> for (i = 0; i < pdata->num_devices; i++)
>

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

\
 
 \ /
  Last update: 2020-09-16 02:50    [W:0.064 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site