lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 006/177] regulator: remove superfluous lock in regulator_resolve_coupling()
    Date
    From: Michał Mirosław <mirq-linux@rere.qmqm.pl>

    [ Upstream commit a577f3456c0a2fac3dee037c483753e6e68f3e49 ]

    The code modifies rdev, but locks c_rdev instead. Remove the lock
    as this is held together by regulator_list_mutex taken in the caller.

    Fixes: f9503385b187 ("regulator: core: Mutually resolve regulators coupling")
    Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
    Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
    Link: https://lore.kernel.org/r/25eb81cefb37a646f3e44eaaf1d8ae8881cfde52.1597195321.git.mirq-linux@rere.qmqm.pl
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/core.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
    index 86107d2e1733e..0ba5ca7082afd 100644
    --- a/drivers/regulator/core.c
    +++ b/drivers/regulator/core.c
    @@ -4891,13 +4891,9 @@ static void regulator_resolve_coupling(struct regulator_dev *rdev)
    return;
    }

    - regulator_lock(c_rdev);
    -
    c_desc->coupled_rdevs[i] = c_rdev;
    c_desc->n_resolved++;

    - regulator_unlock(c_rdev);
    -
    regulator_resolve_coupling(c_rdev);
    }
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-16 01:49    [W:4.127 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site