lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 032/177] scsi: megaraid_sas: Dont call disable_irq from process IRQ poll
    Date
    From: Tomas Henzl <thenzl@redhat.com>

    [ Upstream commit d2af39141eea34ef651961e885f49d96781a1016 ]

    disable_irq() might sleep. Replace it with disable_irq_nosync() which is
    sufficient as irq_poll_scheduled protects against concurrently running
    complete_cmd_fusion() from megasas_irqpoll() and megasas_isr_fusion().

    Link: https://lore.kernel.org/r/20200827165332.8432-1-thenzl@redhat.com
    Fixes: a6ffd5bf681 scsi: megaraid_sas: Call disable_irq from process IRQ poll
    Signed-off-by: Tomas Henzl <thenzl@redhat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
    index fcf03f733e417..1a0e2e4342ad8 100644
    --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
    +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
    @@ -3690,7 +3690,7 @@ int megasas_irqpoll(struct irq_poll *irqpoll, int budget)
    instance = irq_ctx->instance;

    if (irq_ctx->irq_line_enable) {
    - disable_irq(irq_ctx->os_irq);
    + disable_irq_nosync(irq_ctx->os_irq);
    irq_ctx->irq_line_enable = false;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-16 01:49    [W:4.098 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site