lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node
On Tue 15-09-20 15:47:37, Chris Down wrote:
> zangchunxin@bytedance.com writes:
> > + if (signal_pending(current))
> > + return;
>
> This doesn't match your patch title, please update it. :-)

I have to admit I have completely missed this and I think that this
should better be fatal_signal_pending because that would make sure that
the userspace will not see an incomplete operation. This is a general
practice for other bail outs as well.

> After that, you can add:
>
> Acked-by: Chris Down <chris@chrisdown.name>

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2020-09-16 01:03    [W:0.036 / U:4.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site