lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v2 0/3] First bunch of Tulip cleanups
From
From: Moritz Fischer <mdf@kernel.org>
Date: Mon, 14 Sep 2020 21:24:49 -0700

> This series is the first bunch of minor cleanups for the de2104x driver
> to make it look and behave more like a modern driver.
>
> These changes replace some of the non-devres versions with devres
> versions of functions to simplify the error paths.
>
> Next up after this will be the ioremap part.

I really don't consider a "conversion" over to devres for older drivers
a suitable cleanup.

There are no resource handling bugs you are fixing, the driver uses
the APIs it uses correctly, and the coding style is reasonable.

Therefore, I'm sorry I'm not applying these changes.

\
 
 \ /
  Last update: 2020-09-16 00:50    [W:0.029 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site