lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] crypto: stm32/crc32 - Avoid lock if hardware is already used
Date
Hello Herbert,

On 9/11/20 6:28 AM, Herbert Xu wrote:
> On Fri, Sep 04, 2020 at 01:25:27PM +0200, Nicolas Toromanoff wrote:
>> If STM32 CRC device is already in use, calculate CRC by software.
>>
>> This will release CPU constraint for a concurrent access to the
>> hardware, and avoid masking irqs during the whole block processing.
>>
>> Fixes: 7795c0baf5ac ("crypto: stm32/crc32 - protect from concurrent accesses")
>>
>> Signed-off-by: Nicolas Toromanoff <nicolas.toromanoff@st.com>
>> ---
>> drivers/crypto/stm32/Kconfig | 2 ++
>> drivers/crypto/stm32/stm32-crc32.c | 15 ++++++++++++---
>> 2 files changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/stm32/Kconfig b/drivers/crypto/stm32/Kconfig
>> index 4ef3eb11361c..8d605b07571f 100644
>> --- a/drivers/crypto/stm32/Kconfig
>> +++ b/drivers/crypto/stm32/Kconfig
>> @@ -3,6 +3,8 @@ config CRYPTO_DEV_STM32_CRC
>> tristate "Support for STM32 crc accelerators"
>> depends on ARCH_STM32
>> select CRYPTO_HASH
>> + select CRYPTO_CRC32
>> + select CRYPTO_CRC32C
>
> Shouldn't this be "select CRC32"?

Correct "select CRC32" is enough.
I'll send a version 2 with only "select CRC32".


Nicolas.
\
 
 \ /
  Last update: 2020-09-16 00:43    [W:0.048 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site