[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v8 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL
On Wed, Sep 9, 2020 at 1:35 PM Kent Gibson <> wrote:
> Add support for requesting lines using the GPIO_V2_GET_LINE_IOCTL, and
> returning their current values using GPIO_V2_LINE_GET_VALUES_IOCTL.
> The struct linereq implementation is based on the v1 struct linehandle
> implementation.

Seems I have reviewed v7 of this. According to the changelog most of
the comments are still applicable I think.

> Signed-off-by: Kent Gibson <>
> ---
> The linereq_ioctl() is a simple wrapper around linereq_get_values() here,
> but will be extended with other ioctls in subsequent patches.
> Similarly, the struct line only contains the desc here, but will receive
> the edge detector and debouncer fields in subsequent patches.
> Changed for v8:
> - fix BUILD_BUG_ON conditions and relocate them before the return in
> gpiolib_cdev_register()

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2020-09-16 00:42    [W:0.173 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site