lkml.org 
[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH leds + devicetree v2 1/2] leds: trigger: add trigger sources validating method and helper functions
On Tue, 15 Sep 2020 17:26:15 +0200
Marek Behún <marek.behun@nic.cz> wrote:

> + /*
> + * Check whether LED has defined valid source for this trigger.
> + * If yes, this trigger should be set as default trigger for LED.
> + * This should use of_led_count_trigger_sources and
> + * of_led_get_trigger_source functions.
> + */
> + bool (*has_valid_source)(struct led_classdev *led_cdev);

Hmm, the heartbeat and timer triggers do not need trigger sources. If
we want to deprecate linux,default-trigger device tree property for
these triggers also, this method should look to `function` DT property
for heartbeat and timer triggers.

In that case the name should be changed to something like
of_is_valid_default_for, or something like that.

Marek

\
 
 \ /
  Last update: 2020-09-16 00:23    [W:0.081 / U:10.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site