[lkml]   [2020]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node
Michal Hocko writes:
>On Tue 15-09-20 15:47:37, Chris Down wrote:
>> writes:
>> > + if (signal_pending(current))
>> > + return;
>> This doesn't match your patch title, please update it. :-)
>I have to admit I have completely missed this and I think that this
>should better be fatal_signal_pending because that would make sure that
>the userspace will not see an incomplete operation. This is a general
>practice for other bail outs as well.

Oh sorry, to be clear, I meant the patch should match the title, not the other
way around.

 \ /
  Last update: 2020-09-16 00:23    [W:0.056 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site