Messages in this thread | | | Date | Tue, 15 Sep 2020 18:33:12 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record |
| |
On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote: > Memory errors could be printed with incorrect row values since the DIMM > size has outgrown the 16 bit row field in the CPER structure. UEFI > Specification Version 2.8 has increased the size of row by allowing it to > use the first 2 bits from a previously reserved space within the structure. > > When needed, add the extension bits to the row value printed. > > Based on UEFI 2.8 Table 299. Memory Error Record > > Reviewed-by: Kyle Meyer <kyle.meyer@hpe.com> > Reviewed-by: Steve Wahl <steve.wahl@hpe.com> > Tested-by: Russ Anderson <russ.anderson@hpe.com> > Signed-off-by: Alex Kluver <alex.kluver@hpe.com> > --- > > v1 -> v2: > * Add static inline cper_get_mem_extension() to make it > more readable, as suggested by Borislav Petkov. > > * Add second patch for bank field, bank group, and chip id. > > --- > drivers/edac/ghes_edac.c | 8 ++++++-- > drivers/firmware/efi/cper.c | 9 +++++++-- > include/linux/cper.h | 16 ++++++++++++++-- > 3 files changed, 27 insertions(+), 6 deletions(-)
For the EDAC bits:
Acked-by: Borislav Petkov <bp@suse.de>
Also, I could take both through the EDAC tree, if people prefer.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |