Messages in this thread | | | Subject | Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT_RAM | From | Youling Tang <> | Date | Mon, 14 Sep 2020 18:39:51 +0800 |
| |
On 09/14/2020 12:32 PM, Jiaxun Yang wrote: > > > 在 2020/9/12 9:59, Youling Tang 写道: >> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left >> the BOOT_MEM_INIT_RAM unused, remove it. >> >> Signed-off-by: Youling Tang <tangyouling@loongson.cn> >> --- >> arch/mips/include/asm/bootinfo.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/mips/include/asm/bootinfo.h >> b/arch/mips/include/asm/bootinfo.h >> index 147c932..39196ae 100644 >> --- a/arch/mips/include/asm/bootinfo.h >> +++ b/arch/mips/include/asm/bootinfo.h >> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype; >> #define BOOT_MEM_RAM 1 >> #define BOOT_MEM_ROM_DATA 2 >> #define BOOT_MEM_RESERVED 3 >> -#define BOOT_MEM_INIT_RAM 4 > > If you're willing to remove that you'd better turn the memtype struct > into a enum. > Hi Jiaxun, Do you mean to modify it as follows?
enum boot_memtype { BOOT_MEM_RAM, BOOT_MEM_ROM_DATA, BOOT_MEM_RESERVED, BOOT_MEM_NOMAP, };
Thanks.
- Youling > Btw: It seems you've done a lot of minor clean-up works recently, > if you'd like to I think you can try to turn all the platforms into > memblock > and remove all these gules between memblock and legacy code. > > Thanks. > > - Jiaxun > >> #define BOOT_MEM_NOMAP 5 >> extern void add_memory_region(phys_addr_t start, phys_addr_t >> size, long type);
| |