lkml.org 
[lkml]   [2020]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tools/io_uring: fix compile breakage
From
Date
On 9/14/20 3:36 PM, Douglas Gilbert wrote:
> It would seem none of the kernel continuous integration does this:
> $ cd tools/io_uring
> $ make
>
> Otherwise it may have noticed:
> cc -Wall -Wextra -g -D_GNU_SOURCE -c -o io_uring-bench.o
> io_uring-bench.c
> io_uring-bench.c:133:12: error: static declaration of ‘gettid’
> follows non-static declaration
> 133 | static int gettid(void)
> | ^~~~~~
> In file included from /usr/include/unistd.h:1170,
> from io_uring-bench.c:27:
> /usr/include/x86_64-linux-gnu/bits/unistd_ext.h:34:16: note:
> previous declaration of ‘gettid’ was here
> 34 | extern __pid_t gettid (void) __THROW;
> | ^~~~~~
> make: *** [<builtin>: io_uring-bench.o] Error 1
>
> The problem on Ubuntu 20.04 (with lk 5.9.0-rc5) is that unistd.h
> already defines gettid(). So prefix the local definition with
> "lk_".

Thanks Doug - I haven't really been maintaining the examples in
the kernel, only in liburing. I'll apply this one, and hopefully
sync them up for 5.10 in general.


--
Jens Axboe

\
 
 \ /
  Last update: 2020-09-15 03:34    [W:0.024 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site