lkml.org 
[lkml]   [2020]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] dt-bindings: media: imx258: Add bindings for IMX258 sensor
On Wed, Sep 02, 2020 at 09:18:08AM +0200, Krzysztof Kozlowski wrote:
> Add bindings for the IMX258 camera sensor. The bindings, just like the
> driver, are quite limited, e.g. do not support regulator supplies.

Bindings should be complete, not what a driver happens to currently
support.

>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. None
> ---
> .../devicetree/bindings/media/i2c/imx258.yaml | 92 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 93 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/imx258.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/imx258.yaml
> new file mode 100644
> index 000000000000..ef789ad31143
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/imx258.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/imx258.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>
> +
> +description: |-
> + IMX258 is a diagonal 5.867mm (Type 1/3.06) 13 Mega-pixel CMOS active pixel
> + type stacked image sensor with a square pixel array of size 4208 x 3120. It
> + is programmable through I2C interface. Image data is sent through MIPI
> + CSI-2.
> +
> +properties:
> + compatible:
> + const: sony,imx258
> +
> + clocks:
> + maxItems: 1
> +
> + clock-frequency:
> + description: Frequency of input clock if clock is not provided
> + deprecated: true

Why are we adding something deprecated on a new binding?

> + const: 19200000
> +
> + reg:
> + maxItems: 1
> +
> + # See ../video-interfaces.txt for more details
> + port:
> + type: object
> + properties:
> + endpoint:
> + type: object
> + properties:
> + data-lanes:
> + items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4

If this is the only config, why does it need to be in DT?

> +
> + link-frequencies:
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint64-array
> + description:
> + Allowed data bus frequencies.
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> +required:
> + - compatible
> + - reg
> + - port
> +
> +
> +if:
> + not:
> + required:
> + - clocks
> +then:
> + required:
> + - clock-frequency
> +
> +unevaluatedProperties: false

additionalProperties

> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@6c {
> + compatible = "sony,imx258";
> + reg = <0x6c>;
> + clocks = <&imx258_clk>;
> +
> + port {
> + imx258_ep: endpoint {
> + remote-endpoint = <&csi1_ep>;
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <320000000>;
> + };
> + };
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dc2aa691b75a..cca13d483d22 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16130,6 +16130,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com>
> L: linux-media@vger.kernel.org
> S: Maintained
> T: git git://linuxtv.org/media_tree.git
> +F: Documentation/devicetree/bindings/media/i2c/imx258.yaml
> F: drivers/media/i2c/imx258.c
>
> SONY IMX274 SENSOR DRIVER
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2020-09-14 22:15    [W:0.090 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site