Messages in this thread | | | Date | Mon, 14 Sep 2020 13:02:59 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit() |
| |
On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote: > 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the > local variable declaration, not only its usage.
I was actually wondering about this when working on the pause stat patch. Where is MLX4_EN_PERF_STAT ever defined?
$ git grep MLX4_EN_PERF_STAT drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#ifdef MLX4_EN_PERF_STAT drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#endif /* MLX4_EN_PERF_STAT */ drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h:#ifdef MLX4_EN_PERF_STAT
| |