Messages in this thread | | | From | Muchun Song <> | Date | Mon, 14 Sep 2020 11:28:09 +0800 | Subject | Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 |
| |
On Mon, Sep 14, 2020 at 11:19 AM Zefan Li <lizefan@huawei.com> wrote: > > On 2020/9/14 11:10, Muchun Song wrote: > > On Mon, Sep 14, 2020 at 1:09 AM Chris Down <chris@chrisdown.name> wrote: > >> > >> Muchun Song writes: > >>> In the cgroup v1, we have a numa_stat interface. This is useful for > >>> providing visibility into the numa locality information within an > >>> memcg since the pages are allowed to be allocated from any physical > >>> node. One of the use cases is evaluating application performance by > >>> combining this information with the application's CPU allocation. > >>> But the cgroup v2 does not. So this patch adds the missing information. > >>> > >>> Signed-off-by: Muchun Song <songmuchun@bytedance.com> > >>> Suggested-by: Shakeel Butt <shakeelb@google.com> > >>> Reported-by: kernel test robot <lkp@intel.com> > >> > >> This is a feature patch, why does this have LKP's Reported-by? > > > > In the v2 version, the kernel test robot reported a compiler error > > on the powerpc architecture. So I added that. Thanks. > > > > You should remove this reported-by, and then add v2->v3 changelog:
Got it. I see Andrew has done it for me, thank him very much for his work. He also added this patch to the -mm tree.
> > ...original changelog... > > v3: > - fixed something reported by test rebot
I already added that in the changelog. Thanks.
-- Yours, Muchun
| |