lkml.org 
[lkml]   [2020]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 03/10] fs/ntfs3: Add bitmap
On Sun, Sep 13, 2020 at 11:43:50AM -0700, Joe Perches wrote:
> On Fri, 2020-09-11 at 17:10 +0300, Konstantin Komarov wrote:
> > This adds bitmap
>
> $ make fs/ntfs3/
> SYNC include/config/auto.conf.cmd
> CALL scripts/checksyscalls.sh
> CALL scripts/atomic/check-atomics.sh
> DESCEND objtool
> CC fs/ntfs3/bitfunc.o
> CC fs/ntfs3/bitmap.o
> fs/ntfs3/bitmap.c: In function ‘wnd_rescan’:
> fs/ntfs3/bitmap.c:556:4: error: implicit declaration of function ‘page_cache_readahead_unbounded’; did you mean ‘page_cache_ra_unbounded’? [-Werror=implicit-function-declaration]
> 556 | page_cache_readahead_unbounded(
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | page_cache_ra_unbounded
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:283: fs/ntfs3/bitmap.o] Error 1
> make[1]: *** [scripts/Makefile.build:500: fs/ntfs3] Error 2
> make: *** [Makefile:1792: fs] Error 2

That was only just renamed. More concerningly, the documentation is
quite unambiguous:

* This function is for filesystems to call when they want to start
* readahead beyond a file's stated i_size. This is almost certainly
* not the function you want to call. Use page_cache_async_readahead()
* or page_cache_sync_readahead() instead.

\
 
 \ /
  Last update: 2020-09-14 04:39    [W:0.114 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site