Messages in this thread | | | Date | Sat, 12 Sep 2020 11:15:06 +0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [v10 0/4] media: vidtv: Implement a virtual DVB driver |
| |
Hi Hans/Daniel,
Em Sat, 12 Sep 2020 10:21:59 +0200 Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> > Building vidtv > > -------------- > > vidtv is a test driver and thus is **not** enabled by default when > > compiling the kernel. > > > > In order to enable compilation of vidtv: > > > > - Enable **DVB_TEST_DRIVERS**, then > > - Enable **DVB_VIDTV** > > > > When compiled as a module, expect the following .ko files: > > > > - dvb_vidtv_tuner.ko > > > > - dvb_vidtv_demod.ko > > > > - dvb_vidtv_bridge.ko > > Why the dvb_ prefix? All virtual drivers just start with 'vi'. > > And wouldn't it make more sense to call dvb_vidtv_bridge.ko just vidtv.ko? > Just like the other virtual media drivers?
It is a sort of standard to use dvb_* for pure digital tv bridge drivers.
Yet, I agree with you that at least an alias is needed. earlier today, I wrote a patch with such purpose:
https://patchwork.linuxtv.org/project/linux-media/patch/fccf254e33bdd169dde6bdd6f941cf773c82a1c0.1599901499.git.mchehab+huawei@kernel.org/
Still, maybe we should move dvb_vidtv_tuner.ko and dvb_vidtv_demod.ko to dvb-frontends and rename them. Not 100% sure about that, though.
I would also rename vidtv_bridge.c to just vidtv.c.
Thanks, Mauro
| |