lkml.org 
[lkml]   [2020]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] scsi: aacraid: improve compat_ioctl handlers
    On Tue, Sep 08, 2020 at 11:36:21PM +0200, Arnd Bergmann wrote:
    > @@ -243,8 +244,23 @@ static int next_getadapter_fib(struct aac_dev * dev, void __user *arg)
    > struct list_head * entry;
    > unsigned long flags;
    >
    > - if(copy_from_user((void *)&f, arg, sizeof(struct fib_ioctl)))
    > - return -EFAULT;
    > + if (in_compat_syscall()) {
    > + struct compat_fib_ioctl {
    > + u32 fibctx;
    > + s32 wait;
    > + compat_uptr_t fib;
    > + } cf;

    I find the struct declaration deep down in the function a little
    annoying.

    But otherwise this looks good;

    Reviewed-by: Christoph Hellwig <hch@lst.de>

    \
     
     \ /
      Last update: 2020-09-12 09:10    [W:3.369 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site