Messages in this thread | | | From | Michael Kelley <> | Subject | RE: [PATCH v3 09/11] HID: hyperv: Make ringbuffer at least take two pages | Date | Sat, 12 Sep 2020 19:38:29 +0000 |
| |
From: Boqun Feng <boqun.feng@gmail.com> Sent: Thursday, September 10, 2020 7:35 AM > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > least 2 * PAGE_SIZE: one page for the header and at least one page of > the data part (because of the alignment requirement for double mapping). > > So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when > using vmbus_open() to establish the vmbus connection. > > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > Acked-by: Jiri Kosina <jkosina@suse.cz> > --- > Hi Jiri, > > Thanks for your acked-by. I make a small change in this version (casting > 2 * PAGE_SIZE into int to avoid compiler warnings), and it make no > functional change. If the change is inappropriate, please let me know. > > drivers/hid/hid-hyperv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
| |