Messages in this thread | | | Subject | Re: [PATCH] drm/bridge: dw-mipi-dsi: Use kmemdup cf. kmalloc+memcpy | From | Neil Armstrong <> | Date | Fri, 11 Sep 2020 14:57:41 +0200 |
| |
On 09/09/2020 21:02, Alex Dewar wrote: > kmemdup can be used instead of kmalloc+memcpy. Replace an occurrence of > this pattern. > > Issue identified with Coccinelle. > > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > index 52f5c5a2ed64..7e9a62ad56e8 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > @@ -1049,12 +1049,10 @@ static void debugfs_create_files(void *data) > }; > int i; > > - dsi->debugfs_vpg = kmalloc(sizeof(debugfs), GFP_KERNEL); > + dsi->debugfs_vpg = kmemdup(debugfs, sizeof(debugfs), GFP_KERNEL); > if (!dsi->debugfs_vpg) > return; > > - memcpy(dsi->debugfs_vpg, debugfs, sizeof(debugfs)); > - > for (i = 0; i < ARRAY_SIZE(debugfs); i++) > debugfs_create_file(dsi->debugfs_vpg[i].name, 0644, > dsi->debugfs, &dsi->debugfs_vpg[i], >
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Thanks, Neil
| |