lkml.org 
[lkml]   [2020]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 58/62] bnxt_en: Failure to update PHY is not fatal condition.
    Date
    From: Michael Chan <mchan@broadcom.com>

    commit ba41d46fe03223279054e58d570069fdc62fb768 upstream.

    If we fail to update the PHY, we should print a warning and continue.
    The current code to exit is buggy as it has not freed up the NIC
    resources yet.

    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -4623,7 +4623,7 @@ static int __bnxt_open_nic(struct bnxt *
    if (link_re_init) {
    rc = bnxt_update_phy_setting(bp);
    if (rc)
    - goto open_err;
    + netdev_warn(bp->dev, "failed to update phy settings\n");
    }

    if (irq_re_init) {

    \
     
     \ /
      Last update: 2020-09-11 19:29    [W:8.706 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site