lkml.org 
[lkml]   [2020]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kvm/eventfd:do wildcard calculation before list_for_each_entry_safe
From
Date
On 11/09/20 07:56, Yi Li wrote:
> There is no need to calculate wildcard in each loop
> since wildcard is not changed.
>
> Signed-off-by: Yi Li <yili@winhong.com>
> ---
> virt/kvm/eventfd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index d6408bb497dc..c2323c27a28b 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -853,15 +853,17 @@ kvm_deassign_ioeventfd_idx(struct kvm *kvm, enum kvm_bus bus_idx,
> struct eventfd_ctx *eventfd;
> struct kvm_io_bus *bus;
> int ret = -ENOENT;
> + bool wildcard;
>
> eventfd = eventfd_ctx_fdget(args->fd);
> if (IS_ERR(eventfd))
> return PTR_ERR(eventfd);
>
> + wildcard = !(args->flags & KVM_IOEVENTFD_FLAG_DATAMATCH);
> +
> mutex_lock(&kvm->slots_lock);
>
> list_for_each_entry_safe(p, tmp, &kvm->ioeventfds, list) {
> - bool wildcard = !(args->flags & KVM_IOEVENTFD_FLAG_DATAMATCH);
>
> if (p->bus_idx != bus_idx ||
> p->eventfd != eventfd ||
>

Queued, thanks.

Paolo

\
 
 \ /
  Last update: 2020-09-11 19:24    [W:0.038 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site