lkml.org 
[lkml]   [2020]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [v4,3/4] reset-controller: ti: introduce a new reset handler
    From
    Date
    Hi Crystal,

    On Fri, 2020-09-11 at 14:07 +0800, Crystal Guo wrote:
    [...]
    > Should I add the SoC-specific data as follows?
    > This may also modify the ti original code, is it OK?
    >
    > + data->reset_data = of_device_get_match_data(&pdev->dev);
    > +
    > + list = of_get_property(np, data->reset_data->reset_bits, &size);
    >
    > +static const struct common_reset_data ti_reset_data = {
    > + .reset_op_available = false,
    > + .reset_bits = "ti, reset-bits",
    ^
    That space doesn't belong there.

    > +};
    > +
    > +static const struct common_reset_data mediatek_reset_data = {
    > + .reset_op_available = true,
    > + .reset_bits = "mediatek, reset-bits",
    > +};

    I understand Robs comments as meaning "ti,reset-bits" should have been
    called "reset-bits" in the first place, and you shouldn't repeat adding
    the vendor prefix, as that is implied by the compatible. So this should
    probably be just "reset-bits".

    Otherwise this looks like it should work.

    regards
    Philipp

    \
     
     \ /
      Last update: 2020-09-11 18:38    [W:2.341 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site