lkml.org 
[lkml]   [2020]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 23/62] btrfs: Remove redundant extent_buffer_get in get_old_root
    Date
    From: Nikolay Borisov <nborisov@suse.com>

    [ Upstream commit 6c122e2a0c515cfb3f3a9cefb5dad4cb62109c78 ]

    get_old_root used used only by btrfs_search_old_slot to initialise the
    path structure. The old root is always a cloned buffer (either via alloc
    dummy or via btrfs_clone_extent_buffer) and its reference count is 2: 1
    from allocation, 1 from extent_buffer_get call in get_old_root.

    This latter explicit ref count acquire operation is in fact unnecessary
    since the semantic is such that the newly allocated buffer is handed
    over to the btrfs_path for lifetime management. Considering this just
    remove the extra extent_buffer_get in get_old_root.

    Signed-off-by: Nikolay Borisov <nborisov@suse.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/ctree.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
    index 8eac5f75bca36..8765312743f16 100644
    --- a/fs/btrfs/ctree.c
    +++ b/fs/btrfs/ctree.c
    @@ -1441,7 +1441,6 @@ get_old_root(struct btrfs_root *root, u64 time_seq)

    if (!eb)
    return NULL;
    - extent_buffer_get(eb);
    btrfs_tree_read_lock(eb);
    if (old_root) {
    btrfs_set_header_bytenr(eb, eb->start);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-11 15:01    [W:4.057 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site