lkml.org 
[lkml]   [2020]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
From
Date
On 9/11/20 1:00 PM, Mark Brown wrote:
> On Fri, Sep 11, 2020 at 01:58:06PM +0530, kuldip dwivedi wrote:
>
>> /* find the resources - configuration register address space */
>> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_base");
>> +#ifdef CONFIG_ACPI
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +#endif
>
> This is buggy, it is equivalent to just removing the name based lookup
> since we'll do the name based lookup then unconditionally overwrite the
> results with an index based lookup.
>

Also, note that CONFIG_ACPI kernels may still boot in DT mode.

\
 
 \ /
  Last update: 2020-09-11 13:17    [W:0.130 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site