Messages in this thread | | | Date | Fri, 11 Sep 2020 10:15:40 +0000 | From | skakit@codeauro ... | Subject | Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART |
| |
Hi Matthias,
On 2020-09-10 21:05, Matthias Kaehlcke wrote: > El Thu, Sep 10, 2020 at 06:23:56PM +0530 satya priya ha dit: > >> Add a suitable sleep configuration for uart3 to support Bluetooth >> wakeup. >> >> If QUP function is selected in sleep state, UART RTS/RFR is pulled >> high >> during suspend and BT SoC not able to send wakeup bytes. So, configure >> GPIO mode in sleep state to keep it low during suspend. >> >> Signed-off-by: satya priya <skakit@codeaurora.org> >> Reviewed-by: Akash Asthana <akashast@codeaurora.org> > > Was this change really reviewed (privately) by Akash or are you still > carrying forward this tag from v2? The configuration and the comments > have change substantially since v2, IMO you should drop the tag unless > Akash really reviewed the current version or something close to it. >
Okay, will drop the tag.
>> --- >> Changes in V2: >> - This patch adds sleep state for BT UART. Newly added in V2. >> >> Changes in V3: >> - Remove "output-high" for TX from both sleep and default states >> as it is not required. Configure pull-up for TX in sleep state. >> >> Changes in V4: >> - As per Matthias's comment, removed drive-strength for sleep state >> and fixed nit-pick. >> >> Changes in V5: >> - As per Matthias's comments, moved pinmux change for sleep state, >> pinctrl and interrupt config to the board specific file. >> >> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 48 >> +++++++++++++++++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> index 04888df..e529a41 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts >> @@ -344,6 +344,10 @@ >> }; >> >> &uart3 { >> + pinctrl-names = "default", "sleep"; >> + pinctrl-1 = <&qup_uart3_sleep>; >> + interrupts-extended = <&intc GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>, >> + <&tlmm 41 IRQ_TYPE_EDGE_FALLING>; > > As Doug already said, you need to delete the 'interrupts' property now > that we have 'interrupts-extended'.
okay.
Thanks, Satya Priya
| |