lkml.org 
[lkml]   [2020]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360
Hi!

> >+{
> >+ struct mt6360_led *led = container_of(lcdev, struct mt6360_led, flash.led_cdev);
> >+ struct mt6360_priv *priv = led->priv;
> >+ u32 enable_mask = MT6360_TORCHEN_MASK | MT6360_FLCSEN_MASK(led->led_no);
> >+ u32 val = (level) ? MT6360_FLCSEN_MASK(led->led_no) : 0;
> >+ u32 prev = priv->fled_torch_used, curr;
> >+ int ret;
> >+
> >+ dev_dbg(lcdev->dev, "[%d] brightness %d\n", led->led_no, level);
> >+ if (priv->fled_strobe_used) {
> >+ dev_warn(lcdev->dev, "Please disable strobe first [%d]\n", priv->fled_strobe_used);
>
> Doesn't hardware handle that? IOW, what happens when you have enabled
> both torch and flash? If flash just overrides torch mode, than you
> should not prevent enabling torch in this case.

Yep, this is strange/confusing... and was reason why I asked for not
supporting strobe from sysfs.

Could I get you to remove code you are not commenting at when
reviewing?

> >+MODULE_AUTHOR("Gene Chen <gene_chen@richtek.com>");
> >+MODULE_DESCRIPTION("MT6360 Led Driver");

Led -> LED.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-09-11 09:06    [W:0.154 / U:5.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site