Messages in this thread | | | Date | Thu, 10 Sep 2020 11:42:06 -0700 | From | "Luck, Tony" <> | Subject | Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only |
| |
On Thu, Sep 10, 2020 at 08:29:19PM +0200, Borislav Petkov wrote: > Ok, with all those changes, I don't think the following nice and juicy > message can be overlooked: > > [ 32.267830] mce: MSR access error: RDMSR from 0x1234 at rIP: 0xffffffff8102ed62 (mce_rdmsrl+0x12/0x50)
With only one call site the rIP isn't super helpful at the moment. But once you start selling those "MSR or die" T-shirts everyone will want to use this :-)
> [ 32.267838] Call Trace: > [ 32.267838] <#MC> > [ 32.267838] do_machine_check+0xbd/0x9f0 > [ 32.267839] ? trigger_mce+0x7/0x10 > [ 32.267839] exc_machine_check+0x77/0xd0 > [ 32.267840] asm_exc_machine_check+0x19/0x30
Do we need the stack trace twice? Once from your fixup function, second from panic()?
-Tony
| |