lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver
On Thu, Sep 10, 2020 at 04:24:31PM +0000, Eads, Gage wrote:
>
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Monday, September 7, 2020 8:02 AM
> > To: Eads, Gage <gage.eads@intel.com>
> > Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> > <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> > Subject: Re: [PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver
> >
> > On Tue, Sep 01, 2020 at 02:15:30PM -0500, Gage Eads wrote:
> > > --- /dev/null
> > > +++ b/drivers/misc/dlb2/dlb2_main.c
> > > @@ -0,0 +1,208 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/* Copyright(c) 2018-2020 Intel Corporation */
> > > +
> > > +#include <linux/aer.h>
> > > +#include <linux/cdev.h>
> > > +#include <linux/delay.h>
> > > +#include <linux/fs.h>
> > > +#include <linux/init.h>
> > > +#include <linux/list.h>
> > > +#include <linux/module.h>
> > > +#include <linux/pci.h>
> > > +#include <linux/uaccess.h>
> > > +
> > > +#include "dlb2_main.h"
> > > +
> > > +static const char
> > > +dlb2_driver_copyright[] = "Copyright(c) 2018-2020 Intel Corporation";
> > Why have this in a string and then:
> >
> > > +MODULE_LICENSE("GPL v2");
> > > +MODULE_AUTHOR("Copyright(c) 2018-2020 Intel Corporation");
> >
> > Not use it?
> >
> > It's probably not needed at all, right?
> >
> > Don't you get a build warning about this when applying and building this
> > patch?
> >
> > thanks,
> >
> > greg k-h
>
> dlb2_driver_copyright was used in a pr_info() in the v1 patchset that was
> removed at Arnd's recommendation, and I forgot to remove the string. Will fix.
> The unused warning variable was likely missed in the deluge of warnings from
> included kernel headers.

You should not have any build warnings. If you do, then something is
really wrong, the kernel builds cleanly today.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-09-10 18:32    [W:0.150 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site