Messages in this thread | | | Subject | Re: [PATCH v2 -next] drm/amdkfd: Fix -Wunused-const-variable warning | From | Felix Kuehling <> | Date | Thu, 10 Sep 2020 10:32:22 -0400 |
| |
Am 2020-09-10 um 3:50 a.m. schrieb YueHaibing: > If KFD_SUPPORT_IOMMU_V2 is not set, gcc warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:121:37: warning: ‘raven_device_info’ defined but not used [-Wunused-const-variable=] > static const struct kfd_device_info raven_device_info = { > ^~~~~~~~~~~~~~~~~ > > As Huang Rui suggested, Raven already has the fallback path, > so it should be out of IOMMU v2 flag. > > Suggested-by: Huang Rui <ray.huang@amd.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I applied your patch to the amd-staging-drm-next branch.
Thank you, Felix
> --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > index 0e71a0543f98..e3fc6ed7b79c 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > @@ -503,8 +503,8 @@ static const struct kfd_device_info *kfd_supported_devices[][2] = { > #ifdef KFD_SUPPORT_IOMMU_V2 > [CHIP_KAVERI] = {&kaveri_device_info, NULL}, > [CHIP_CARRIZO] = {&carrizo_device_info, NULL}, > - [CHIP_RAVEN] = {&raven_device_info, NULL}, > #endif > + [CHIP_RAVEN] = {&raven_device_info, NULL}, > [CHIP_HAWAII] = {&hawaii_device_info, NULL}, > [CHIP_TONGA] = {&tonga_device_info, NULL}, > [CHIP_FIJI] = {&fiji_device_info, &fiji_vf_device_info},
| |