lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH -next] regulator: bd718x7: Make some variable static
Date

On Thu, 2020-09-10 at 11:42 +0800, YueHaibing wrote:
> Fix sparse warnings:
>
> drivers/regulator/bd718x7-regulator.c:576:28: warning: symbol
> 'bd71847_swcontrol_ops' was not declared. Should it be static?
> drivers/regulator/bd718x7-regulator.c:585:28: warning: symbol
> 'bd71847_hwcontrol_ops' was not declared. Should it be static?
> drivers/regulator/bd718x7-regulator.c:902:28: warning: symbol
> 'bd71837_swcontrol_ops' was not declared. Should it be static?
> drivers/regulator/bd718x7-regulator.c:913:28: warning: symbol
> 'bd71837_hwcontrol_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Thanks for taking care of this!

> ---
> drivers/regulator/bd718x7-regulator.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/bd718x7-regulator.c
> b/drivers/regulator/bd718x7-regulator.c
> index 159c917b9c4c..0774467994fb 100644
> --- a/drivers/regulator/bd718x7-regulator.c
> +++ b/drivers/regulator/bd718x7-regulator.c
> @@ -573,7 +573,7 @@ static int buck_set_hw_dvs_levels(struct
> device_node *np,
> return rohm_regulator_set_dvs_levels(&data->dvs, np, desc, cfg-
> >regmap);
> }
>
> -const struct regulator_ops *bd71847_swcontrol_ops[] = {
> +static const struct regulator_ops *bd71847_swcontrol_ops[] = {
> &bd718xx_dvs_buck_regulator_ops,
> &bd718xx_dvs_buck_regulator_ops,
> &bd718xx_pickable_range_buck_ops,
> &bd718xx_pickable_range_buck_ops,
> &bd718xx_buck_regulator_nolinear_ops,
> &bd718xx_buck_regulator_ops,
> @@ -582,7 +582,7 @@ const struct regulator_ops
> *bd71847_swcontrol_ops[] = {
> &bd718xx_pickable_range_ldo_ops, &bd718xx_ldo_regulator_ops,
> };
>
> -const struct regulator_ops *bd71847_hwcontrol_ops[] = {
> +static const struct regulator_ops *bd71847_hwcontrol_ops[] = {
> &BD718XX_HWOPNAME(bd718xx_dvs_buck_regulator_ops),
> &BD718XX_HWOPNAME(bd718xx_dvs_buck_regulator_ops),
> &BD718XX_HWOPNAME(bd718xx_pickable_range_buck_ops),
> @@ -899,7 +899,7 @@ static struct bd718xx_regulator_data
> bd71847_regulators[] = {
> },
> };
>
> -const struct regulator_ops *bd71837_swcontrol_ops[] = {
> +static const struct regulator_ops *bd71837_swcontrol_ops[] = {
> &bd718xx_dvs_buck_regulator_ops,
> &bd718xx_dvs_buck_regulator_ops,
> &bd718xx_dvs_buck_regulator_ops,
> &bd718xx_dvs_buck_regulator_ops,
> &bd71837_pickable_range_buck_ops, &bd71837_buck_regulator_ops,
> @@ -910,7 +910,7 @@ const struct regulator_ops
> *bd71837_swcontrol_ops[] = {
> &bd71837_ldo_regulator_ops,
> };
>
> -const struct regulator_ops *bd71837_hwcontrol_ops[] = {
> +static const struct regulator_ops *bd71837_hwcontrol_ops[] = {
> &BD718XX_HWOPNAME(bd718xx_dvs_buck_regulator_ops),
> &BD718XX_HWOPNAME(bd718xx_dvs_buck_regulator_ops),
> &bd71837_buck34_ops_hwctrl, &bd71837_buck34_ops_hwctrl,

\
 
 \ /
  Last update: 2020-09-10 07:03    [W:0.049 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site