lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()
    Date
    Hi viro,
    Could I get your feedback?
    This patch fixed the build warning, I think it can be applied, thanks :)

    -----Original Message-----
    From: tianxianting (RD)
    Sent: Saturday, September 05, 2020 3:15 PM
    To: viro@zeniv.linux.org.uk
    Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) <tian.xianting@h3c.com>
    Subject: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()

    Fix warning when compiling with W=1:
    fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size'
    fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size'

    Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
    ---
    fs/read_write.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/read_write.c b/fs/read_write.c
    index 5db58b8c7..058563ee2 100644
    --- a/fs/read_write.c
    +++ b/fs/read_write.c
    @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos);
    * @file: file structure to seek on
    * @offset: file offset to seek to
    * @whence: type of seek
    - * @size: max size of this file in file system
    + * @maxsize: max size of this file in file system
    * @eof: offset used for SEEK_END position
    *
    * This is a variant of generic_file_llseek that allows passing in a custom
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-09-11 04:07    [W:4.931 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site