lkml.org 
[lkml]   [2020]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN links
From
From: Era Mayflower <mayflowerera@gmail.com>
Date: Thu, 10 Sep 2020 09:56:09 +0000

> - pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN;
> - if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) {
> - pr_notice("macsec: nl: upd_rxsa: bad pn length: %d != %d\n",
> - nla_len(tb_sa[MACSEC_SA_ATTR_PN]), pn_len);
> + pr_notice("macsec: nl: upd_rxsa: pn length on non-xpn links must be %d\n",
> + MACSEC_DEFAULT_PN_LEN);
> + rtnl_unlock();
> + return -EINVAL;
> +
> + default:
> + pr_notice("macsec: nl: upd_rxsa: pn length must be %d or %d\n",
> + MACSEC_DEFAULT_PN_LEN, MACSEC_XPN_PN_LEN);
> rtnl_unlock();

Please do not spam the kernel log like this. Instead, report this
info via netlink extended ACKs.

Thank you.

\
 
 \ /
  Last update: 2020-09-11 00:06    [W:0.427 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site