Messages in this thread | | | Date | Thu, 10 Sep 2020 22:31:18 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs |
| |
> We already have different support for blinking in LED subsystem. Lets use that.
You are assuming we have full software control of the LED, we can turn it on and off. That is not always the case. But there is sometimes a mode which the hardware blinks the LED.
Being able to blink the LED is useful:
ethtool(1):
-p --identify
Initiates adapter-specific action intended to enable an operator to easily identify the adapter by sight. Typically this involves blinking one or more LEDs on the specific network port.
Once we get LED support in, i expect we will make use of this blink mode for this ethtool option.
Andrew
| |