lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 191/255] usb: renesas-xhci: remove version check
    Date
    From: Vinod Koul <vkoul@kernel.org>

    commit d66a57be2f9a315fc10d0f524f670fec903e0fb4 upstream.

    Some devices in wild are reporting bunch of firmware versions, so remove
    the check for versions in driver

    Reported by: Anastasios Vacharakis <vacharakis@gmail.com>
    Reported by: Glen Journeay <journeay@gmail.com>
    Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201")
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208911
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Cc: stable <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200818071739.789720-1-vkoul@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/xhci-pci-renesas.c | 19 +------------------
    1 file changed, 1 insertion(+), 18 deletions(-)

    --- a/drivers/usb/host/xhci-pci-renesas.c
    +++ b/drivers/usb/host/xhci-pci-renesas.c
    @@ -50,20 +50,6 @@
    #define RENESAS_RETRY 10000
    #define RENESAS_DELAY 10

    -#define ROM_VALID_01 0x2013
    -#define ROM_VALID_02 0x2026
    -
    -static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version)
    -{
    - switch (version) {
    - case ROM_VALID_01:
    - case ROM_VALID_02:
    - return 0;
    - }
    - dev_err(&pdev->dev, "FW has invalid version :%d\n", version);
    - return -EINVAL;
    -}
    -
    static int renesas_fw_download_image(struct pci_dev *dev,
    const u32 *fw, size_t step, bool rom)
    {
    @@ -202,10 +188,7 @@ static int renesas_check_rom_state(struc

    version &= RENESAS_FW_VERSION_FIELD;
    version = version >> RENESAS_FW_VERSION_OFFSET;
    -
    - err = renesas_verify_fw_version(pdev, version);
    - if (err)
    - return err;
    + dev_dbg(&pdev->dev, "Found ROM version: %x\n", version);

    /*
    * Test if ROM is present and loaded, if so we can skip everything

    \
     
     \ /
      Last update: 2020-09-01 17:48    [W:4.212 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site