lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] perf: correct SNOOPX field offset
    Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu:
    > On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote:
    > > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu:
    > > > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote:
    > > > > perf_event.h has macros that define the field offsets in the
    > > > > data_src bitmask in perf records. The SNOOPX and REMOTE offsets
    > > > > were both 37. These are distinct fields, and the bitfield layout
    > > > > in perf_mem_data_src confirms that SNOOPX should be at offset 38.
    > > >
    > > > Looks good.
    > > >
    > > > Reviewed-by: Andi Kleen <ak@linux.intel.com>
    > > >
    > > > Probably should have a Fixes: header
    > >
    > > Please do so, find the patch that introduced the error, add the Fixes
    > > tag, will help me not having to do it myself :-)
    >
    > Fixes: 52839e653b562 ("perf tools: Add support for printing new mem_info
    > encodings")

    Ok, I'll add that, thanks.

    But you forgot to add your Signed-off-by:, can you please provide it?

    There was also a minor problem in the patch, there was no separation of
    --- from the patch comment section to the patch itself, I'll fix that as
    well.

    - Arnaldo

    \
     
     \ /
      Last update: 2020-09-01 17:02    [W:4.364 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site