Messages in this thread | | | Subject | Re: [16/32] brcmfmac: btcoex: Update 'brcmf_btcoex_state' and demote others | From | Kalle Valo <> | Date | Tue, 1 Sep 2020 09:23:15 +0000 (UTC) |
| |
Lee Jones <lee.jones@linaro.org> wrote:
> The function headers are either very weakly documented or not at all. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: Function parameter or member 'reg50' not described in 'brcmf_btcoex_info' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:94: warning: Function parameter or member 'saved_regs_part2' not described in 'brcmf_btcoex_info' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:233: warning: Function parameter or member 'btci' not described in 'btcmf_btcoex_save_part1' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:253: warning: Function parameter or member 'btci' not described in 'brcmf_btcoex_restore_part1' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:273: warning: Function parameter or member 't' not described in 'brcmf_btcoex_timerfunc' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Function parameter or member 'vif' not described in 'brcmf_btcoex_set_mode' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Function parameter or member 'duration' not described in 'brcmf_btcoex_set_mode' > drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:453: warning: Excess function parameter 'cfg' description in 'brcmf_btcoex_set_mode' > > Cc: Arend van Spriel <arend.vanspriel@broadcom.com> > Cc: Franky Lin <franky.lin@broadcom.com> > Cc: Hante Meuleman <hante.meuleman@broadcom.com> > Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com> > Cc: Wright Feng <wright.feng@cypress.com> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: brcm80211-dev-list@cypress.com > Cc: netdev@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org>
7 patches applied to wireless-drivers-next.git, thanks.
9d16c3859012 brcmfmac: btcoex: Update 'brcmf_btcoex_state' and demote others 03a7c2ea609b b43: phy_ht: Remove 9 year old TODO 5316050efdde rsi: Source file headers are not suitable for kernel-doc 3ecf6a3d6f62 iwlegacy: 4965-rs: Demote non kernel-doc headers to standard comment blocks fa5768d59c53 iwlegacy: 4965-calib: Demote seemingly accidental kernel-doc header a940977aaf2a brcmfmac: fwsignal: Remove unused variable 'brcmf_fws_prio2fifo' e9cf68ff4eff rtlwifi: rtl8192c: phy_common: Remove unused variable 'bbvalue'
-- https://patchwork.kernel.org/patch/11728347/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |