Messages in this thread | | | From | "Wan Mohamad, Wan Ahmad Zainie" <> | Subject | RE: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support | Date | Tue, 1 Sep 2020 04:49:25 +0000 |
| |
Hi Vinod.
Thanks for the review.
> -----Original Message----- > From: Vinod Koul <vkoul@kernel.org> > Sent: Monday, August 31, 2020 5:20 PM > To: Wan Mohamad, Wan Ahmad Zainie > <wan.ahmad.zainie.wan.mohamad@intel.com> > Cc: kishon@ti.com; robh+dt@kernel.org; Shevchenko, Andriy > <andriy.shevchenko@intel.com>; eswara.kota@linux.intel.com; > vadivel.muruganx.ramuthevar@linux.intel.com; Raja Subramanian, Lakshmi > Bai <lakshmi.bai.raja.subramanian@intel.com>; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support > > On 21-08-20, 19:37, Wan Ahmad Zainie wrote: > > > +/* From ACS_eMMC51_16nFFC_RO1100_Userguide_v1p0.pdf p17 */ > > +#define FREQSEL_200M_170M 0x0 > > +#define FREQSEL_170M_140M 0x1 > > +#define FREQSEL_140M_110M 0x2 > > +#define FREQSEL_110M_80M 0x3 > > +#define FREQSEL_80M_50M 0x4 > > + > > +#define maskval(mask, val) (((val) << (ffs(mask) - 1)) & mask) > > Kernel has a macro do this for you, please use FIELD_PREP instead of
I have updated to v8, to remove this macro and use FIELD_PREP. I also add changes based on Andy's comments.
> > your own macro > -- > ~Vinod
Best regards, Zainie
| |