Messages in this thread | | | From | Joel Fernandes <> | Date | Tue, 1 Sep 2020 21:11:18 -0400 | Subject | Re: [RFC PATCH v7 08/23] sched: Add core wide task selection and scheduling. |
| |
On Tue, Sep 1, 2020 at 5:23 PM Vineeth Pillai <viremana@linux.microsoft.com> wrote: > > Also, Peter said pick_seq is for core-wide picking. If you want to add > > another semantic, then maybe add another counter which has a separate > > meaning and justify why you are adding it. > I think just one counter is enough. Unless, there is a need to keep the > counter > to track core wide pick, I feel it is worth to change the design and > make the > counter serve its purpose. Will think through this and send it as a separate > patch if needed.
Since you agree that it suffices to set core_pick to NULL if you don't IPI a sibling, I don't see the need for your split pick_seq thing. But let me know if I missed something.
thanks,
- Joel
| |