lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 23/62] drm/nouveau: Fix reference count leak in nouveau_connector_detect
    Date
    From: Aditya Pakki <pakki001@umn.edu>

    [ Upstream commit 990a1162986e8eff7ca18cc5a0e03b4304392ae2 ]

    nouveau_connector_detect() calls pm_runtime_get_sync and in turn
    increments the reference count. In case of failure, decrement the
    ref count before returning the error.

    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
    index 1855b475cc0b2..42be04813b682 100644
    --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
    @@ -263,8 +263,10 @@ nouveau_connector_detect(struct drm_connector *connector, bool force)
    pm_runtime_get_noresume(dev->dev);
    } else {
    ret = pm_runtime_get_sync(dev->dev);
    - if (ret < 0 && ret != -EACCES)
    + if (ret < 0 && ret != -EACCES) {
    + pm_runtime_put_autosuspend(dev->dev);
    return conn_status;
    + }
    }

    nv_encoder = nouveau_connector_ddc_detect(connector);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-01 19:21    [W:4.328 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site