lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 038/125] drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open
    Date
    From: Aditya Pakki <pakki001@umn.edu>

    [ Upstream commit bfad51c7633325b5d4b32444efe04329d53297b2 ]

    nouveau_fbcon_open() calls calls pm_runtime_get_sync() that
    increments the reference count. In case of failure, decrement the
    ref count before returning the error.

    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
    index 406cb99af7f21..d4fe52ec4c966 100644
    --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
    @@ -189,8 +189,10 @@ nouveau_fbcon_open(struct fb_info *info, int user)
    struct nouveau_fbdev *fbcon = info->par;
    struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev);
    int ret = pm_runtime_get_sync(drm->dev->dev);
    - if (ret < 0 && ret != -EACCES)
    + if (ret < 0 && ret != -EACCES) {
    + pm_runtime_put(drm->dev->dev);
    return ret;
    + }
    return 0;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-01 19:09    [W:4.044 / U:0.640 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site