lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] signal: clean up codestyle
On Tue, Sep 01, 2020 at 06:39:05PM +0200, Oleg Nesterov wrote:
> On 09/01, Christian Brauner wrote:
> >
> > On Tue, Sep 01, 2020 at 07:58:00AM -0400, Miaohe Lin wrote:
> > > No functional change intended.
> >
> > Hey Miaohe,
> >
> > Thank you for the patch.
> > I'm sure this is well-intended but afaict the whole file has more or
> > less a consistent style already where e.g. sig-1 without spaces seems to
> > be preferred. The same for the casts where most places use a single
> > space.
> >
> > Now, I know CodingStyle.rst is on your side at least when it comes to
> > the first point:
> >
> > Use one space around (on each side of) most binary and ternary operators,
> > such as any of these::
> >
> > = + - < > * / % | & ^ <= >= == != ? :
> >
> > but then you'd need to change each place in kernel/signal.c where that
> > is currently not the case.
>
> Or simply leave this code alone ;)

I was trying to imply that by pointing out that this would be
file-global change. I was likely too subtle. ;)

Christian

\
 
 \ /
  Last update: 2020-09-01 18:43    [W:0.049 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site