lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 030/214] drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit 9ba8923cbbe11564dd1bf9f3602add9a9cfbb5c6 ]

    in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the
    counter even in case of failure, leading to incorrect
    ref count. In case of failure, decrement the ref count before returning.

    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
    index 2a7da26008a27..fcc5905a7535d 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
    @@ -976,7 +976,7 @@ int amdgpu_driver_open_kms(struct drm_device *dev, struct drm_file *file_priv)

    r = pm_runtime_get_sync(dev->dev);
    if (r < 0)
    - return r;
    + goto pm_put;

    fpriv = kzalloc(sizeof(*fpriv), GFP_KERNEL);
    if (unlikely(!fpriv)) {
    @@ -1027,6 +1027,7 @@ error_pasid:

    out_suspend:
    pm_runtime_mark_last_busy(dev->dev);
    +pm_put:
    pm_runtime_put_autosuspend(dev->dev);

    return r;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-01 18:31    [W:4.062 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site