lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 136/214] scsi: fcoe: Fix I/O path allocation
    Date
    From: Mike Christie <michael.christie@oracle.com>

    [ Upstream commit fa39ab5184d64563cd36f2fb5f0d3fbad83a432c ]

    ixgbe_fcoe_ddp_setup() can be called from the main I/O path and is called
    with a spin_lock held, so we have to use GFP_ATOMIC allocation instead of
    GFP_KERNEL.

    Link: https://lore.kernel.org/r/1596831813-9839-1-git-send-email-michael.christie@oracle.com
    cc: Hannes Reinecke <hare@suse.de>
    Reviewed-by: Lee Duncan <lduncan@suse.com>
    Signed-off-by: Mike Christie <michael.christie@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
    index ccd852ad62a4b..d50c5b55da180 100644
    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
    @@ -192,7 +192,7 @@ static int ixgbe_fcoe_ddp_setup(struct net_device *netdev, u16 xid,
    }

    /* alloc the udl from per cpu ddp pool */
    - ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_KERNEL, &ddp->udp);
    + ddp->udl = dma_pool_alloc(ddp_pool->pool, GFP_ATOMIC, &ddp->udp);
    if (!ddp->udl) {
    e_err(drv, "failed allocated ddp context\n");
    goto out_noddp_unmap;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-01 18:25    [W:4.163 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site