lkml.org 
[lkml]   [2020]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 118/255] spi: stm32h7: fix race condition at end of transfer
    Date
    From: Antonio Borneo <antonio.borneo@st.com>

    [ Upstream commit 135dd873d3c76d812ae64c668adef3f2c59ed27f ]

    The caller of stm32_spi_transfer_one(), spi_transfer_one_message(),
    is waiting for us to call spi_finalize_current_transfer() and will
    eventually schedule a new transfer, if available.
    We should guarantee that the spi controller is really available
    before calling spi_finalize_current_transfer().

    Move the call to spi_finalize_current_transfer() _after_ the call
    to stm32_spi_disable().

    Signed-off-by: Antonio Borneo <antonio.borneo@st.com>
    Signed-off-by: Alain Volmat <alain.volmat@st.com>
    Link: https://lore.kernel.org/r/1597043558-29668-2-git-send-email-alain.volmat@st.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-stm32.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
    index 13f3d959759fb..fce679635829c 100644
    --- a/drivers/spi/spi-stm32.c
    +++ b/drivers/spi/spi-stm32.c
    @@ -972,8 +972,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id)
    spin_unlock_irqrestore(&spi->lock, flags);

    if (end) {
    - spi_finalize_current_transfer(master);
    stm32h7_spi_disable(spi);
    + spi_finalize_current_transfer(master);
    }

    return IRQ_HANDLED;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-01 18:05    [W:4.230 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site