| Date | Tue, 4 Aug 2020 16:56:34 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access |
| |
On Mon, 3 Aug 2020 17:00:01 -0400 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> mlxbf-tmfifo accesses config space using native types - > which works for it since the legacy virtio native types. > > This will break if it ever needs to support modern virtio, > so with new tags previously introduced for virtio net config, > sparse now warns for this in drivers. > > Since this is a legacy only device, fix it up using > virtio_legacy_is_little_endian for now.
I'm wondering if the driver should make this more explicit?
No issues with the patch, though.
> > No functional changes. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/platform/mellanox/mlxbf-tmfifo.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
|