Messages in this thread | | | From | linmiaohe <> | Subject | Re: [PATCH] mac80211: use eth_zero_addr() to clear mac address | Date | Tue, 4 Aug 2020 11:43:24 +0000 |
| |
> David Miller wrote: >>From: linmiaohe <linmiaohe@huawei.com> >>Date: Sat, 1 Aug 2020 17:12:38 +0800 >> >> From: Miaohe Lin <linmiaohe@huawei.com> >> >> Use eth_zero_addr() to clear mac address instead of memset(). >> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> > >If you're going to make this change, you should probably convert this macro to use eth_addr_copy() at the same time.
Many thanks for your reply. I think we should not convert this macro to use ether_addr_copy (). Because ether_addr_copy() required @dst and @src must both be aligned to u16 and we may not always meet this condition.
Thanks again.
| |