Messages in this thread | | | Date | Tue, 04 Aug 2020 08:53:15 +0200 | From | Martin Schiller <> | Subject | Re: [PATCH v2] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len |
| |
On 2020-07-30 10:02, Xie He wrote: > Hi Martin, > > I'm currently working on a plan to make all X.25 drivers (lapbether.c, > x25_asy.c, hdlc_x25.c) to set dev->hard_header_len / > dev->needed_headroom correctly. So that upper layers no longer need to > guess how much headroom a X.25 device needs with a constant value (as > they currently do). > > After studying af_packet.c, I found that X.25 drivers needed to set > needed_headroom to reserve the headroom instead of using > hard_header_len. Because hard_header_len should be the length of the > header that would be created by dev_hard_header, and in this case it > should be 0, according to the logic of af_packet.c. > > So my first step is to fix the settings in lapbether.c. Could you > review this patch and extend your support via a "Reviewed-by" tag? If > this can be fixed, I'll go on and fix other X.25 drivers. Thanks! > > It's very hard to find reviewers for X.25 code because it is > relatively unmaintained by people. I hope I can do some of the > maintenance work. I greatly appreciate your support!
I don't like the idea to get rid of the 1-byte header. This header is also used in userspace, for example when using a tun/tap interface for an XoT (X.25 over TCP) application. A change would therefore have very far-reaching consequences.
BTW: The linux x25 mailing list does not seem to work anymore. I've been on it for some time now, but haven't received a single email from it. I've tried to contact owner-linux-x25@vger.kernel.org, but only got an "undeliverable" email back.
It would be great if you could add me to CC list of all versions of your patches, so I don't need to "google" for any further related mails.
So, what's the latest version of the patch now, which you want me to review?
| |